Brian J. Watson
2005-04-20 17:55:29 UTC
Yuck! Duplication.
I understand why you had to do this, but I don't like it. It's making me
think that perhaps we should spin off a libssi that contains all the
OpenSSI-specific libcluster routines and make it part of openssi-tools.
Then this source file, which would be part of libssi, could properly
depend on <net/ip_vs.h>.
Another solution that's uglier, but easier to implement, is to move
kernel/include/net/ip_vs.h from the OpenSSI repository to the CI
repository, for no reason other than to properly satisfy this dependency.
Anybody else have opinions on the matter?
Brian
I understand why you had to do this, but I don't like it. It's making me
think that perhaps we should spin off a libssi that contains all the
OpenSSI-specific libcluster routines and make it part of openssi-tools.
Then this source file, which would be part of libssi, could properly
depend on <net/ip_vs.h>.
Another solution that's uglier, but easier to implement, is to move
kernel/include/net/ip_vs.h from the OpenSSI repository to the CI
repository, for no reason other than to properly satisfy this dependency.
Anybody else have opinions on the matter?
Brian
Update of /cvsroot/ci-linux/ci/cluster-tools/libcluster
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv3965
Tag: OPENSSI-DEBIAN
set_ipvsportweight.c
fix build break. With CI we don't have ip_vs.h
Index: set_ipvsportweight.c
===================================================================
RCS file: /cvsroot/ci-linux/ci/cluster-tools/libcluster/set_ipvsportweight.c,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -d -r1.4 -r1.5
--- set_ipvsportweight.c 14 Apr 2005 07:26:59 -0000 1.4
+++ set_ipvsportweight.c 20 Apr 2005 11:36:22 -0000 1.5
@@ -24,7 +24,10 @@
#include <netinet/in.h>
#include <arpa/inet.h>
#include <errno.h>
-#include <net/ip_vs.h>
+
+/* SSI_XXX This should match the def in net/ip_vs.h */
+#define IP_VS_SCHEDNAME_MAXLEN 16
+
/* This should actually go in a header */
-------------------------------------------------------
This SF.Net email is sponsored by: New Crystal Reports XI.
Version 11 adds new functionality designed to reduce time involved in
creating, integrating, and deploying reporting solutions. Free runtime info,
new features, or free trial, at: http://www.businessobjects.com/devxi/728
_______________________________________________
Ci-linux-checkins mailing list
https://lists.sourceforge.net/lists/listinfo/ci-linux-checkins
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv3965
Tag: OPENSSI-DEBIAN
set_ipvsportweight.c
fix build break. With CI we don't have ip_vs.h
Index: set_ipvsportweight.c
===================================================================
RCS file: /cvsroot/ci-linux/ci/cluster-tools/libcluster/set_ipvsportweight.c,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -d -r1.4 -r1.5
--- set_ipvsportweight.c 14 Apr 2005 07:26:59 -0000 1.4
+++ set_ipvsportweight.c 20 Apr 2005 11:36:22 -0000 1.5
@@ -24,7 +24,10 @@
#include <netinet/in.h>
#include <arpa/inet.h>
#include <errno.h>
-#include <net/ip_vs.h>
+
+/* SSI_XXX This should match the def in net/ip_vs.h */
+#define IP_VS_SCHEDNAME_MAXLEN 16
+
/* This should actually go in a header */
-------------------------------------------------------
This SF.Net email is sponsored by: New Crystal Reports XI.
Version 11 adds new functionality designed to reduce time involved in
creating, integrating, and deploying reporting solutions. Free runtime info,
new features, or free trial, at: http://www.businessobjects.com/devxi/728
_______________________________________________
Ci-linux-checkins mailing list
https://lists.sourceforge.net/lists/listinfo/ci-linux-checkins